elastic / elastic/apm-agent-nodejs
Disable payload compression for localhost
- Dominant language
- JavaScript
- Stars
- 594
- Forks
- 244
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 16
Description
Per https://github.com/elastic/apm/pull/518 agents "SHOULD" disable compression on intake requests to localhost. This includes the lambda environment.
- We should *measure* for the Node.js APM agent, for lambda and not. In a heavy load case this would mean a lot more separate intake requests as `apiRequestBytes` is hit. However, the case in a Lambda will likely differ as a single invocation is always flushed it likely (?) won't hit that apiRequestBytes size.
- The spec PR above suggests for the Lambda ext: "If the agent sends uncompressed data, compress it when reading the data and buffer it in an compressed byte array." Is the extension actually doing this now? My limited read of the `ioutil.ReadAll()` suggests not. So there would presumably be larger (approaching 768kB) blips in memory usage of the ext.
Contributor guide
Assessment
This issue has not been assessed yet.