elastic / elastic/apm-agent-nodejs

express-graphql >=0.10.0 instrumentation with node <10.4 doesn't work

Open
#2,516 0 comments 0 reactions 0 assignees View on GitHub
agent-nodejs bug
Dominant language
JavaScript
Stars
594
Forks
244
Avg merge
1d 8h
Merged PRs (30d)
16

Description

The work in https://github.com/elastic/apm-agent-nodejs/pull/2511 to add support for more recent versions of `express-graphql` hit an issue: There is some issue with express-graphql `>=0.10.0` and node `<10.4` (released 2018-06-06) such that the wrapped `graphql.execute` called by express-graphql is not in the run context of the transaction, so the graphql span does not get created and the transaction does not get marked as a GraphQL transaction.

It works with express-graphql@0.9.0, FWIW. I'm not sure what is going on; but I'm also not sure it is worth supporting given node v10 is EOL at this point.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.