elastic / elastic/apm-agent-nodejs
Tedious: Bulk Insert Instrumentation
- Dominant language
- JavaScript
- Stars
- 594
- Forks
- 244
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 16
Description
The [tedious framework](https://www.npmjs.com/package/tedious) is a javascript framework for communicating with Microsoft's SQL Server. The Node.js Agent already [instruments this framework](https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/tedious.js)
However -- in addition to running single SQL queries, the tedious framework includes a ["bulkLoad" API](https://tediousjs.github.io/tedious/bulk-load.html) that allows client programmers to perform a bulk insert of data. The Agent does not currently instrument these bulk insert methods. We should
1. Identify the ideal spans to create for bulk inserts with tedious
2. Implement this instrumentation.
If you're a tedious user please let us know if there's anything in particular that's important for you to see w/r/t to bulk insert instrumentation in the comments below.
See also:
- https://discuss.elastic.co/t/apm-agent-crashes-nodejs-after-reporting-exception-in-tedious-instrumentation-code/259851
- https://github.com/elastic/apm-agent-nodejs/pull/1935
Contributor guide
Assessment
This issue has not been assessed yet.