elastic / elastic/apm-agent-nodejs

Investigation about async-hooks

Open
#1,697 3 comments 1 reaction 0 assignees View on GitHub
agent-nodejs performance
Dominant language
JavaScript
Stars
594
Forks
244
Avg merge
1d 8h
Merged PRs (30d)
16

Description

In a script of mine, where I heavily use use callbacks, seems to get an extremely high spike of calls of the function `destroy` in the `async-hooks` file. https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/async-hooks.js#L103

Screen Shot 2020-03-30 at 10 25 04 AM

Screen Shot 2020-03-30 at 12 58 01 PM

All the green spans are for `internal/async_hooks.js`, and the blue below is the mentioned `destroy` function.

For me it's now a question if we should not remove this async monitoring all together. It uses a lot of computation power which could be used for the actual task.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.