elastic / elastic/apm-agent-java

Make sure we don't instrument library versions we didn't test against

Open
#895 0 comments 0 reactions 0 assignees View on GitHub
enhancement instrumentation technical-debt
Dominant language
Java
Stars
594
Forks
338
Avg merge
1d 13h
Merged PRs (30d)
25

Description

This is a meta issue

- [ ] Make sure to test the latest versions of a library/framework/app server.
Instead of manually specifying the latest version, we should use `latest` for the application server integration tests and maven version ranges to always test the latest versions. We don't necessarily have to test every minor version separately, as long as we make sure we have already tested an outdated minor version in the past. That assumes bugfix releases in an outdated minor version don't break our instrumentations which should be a fair default assumption.
- [ ] Go through all of the instrumentations and add a safeguard to not instrument non-supported versions
- [ ] apm-apache-httpclient-plugin
- [ ] apm-api-plugin
- [ ] apm-asynchttpclient-plugin
- [ ] apm-error-logging-plugin
- [ ] apm-es-restclient-plugin
- [ ] apm-hibernate-search-plugin
- [ ] apm-httpclient-core
- [ ] apm-java-concurrent-plugin
- [ ] apm-jaxrs-plugin
- [ ] apm-jaxws-plugin
- [ ] apm-jdbc-plugin
- [ ] apm-jms-plugin
- [ ] apm-jmx-plugin
- [ ] apm-jsf-plugin
- [ ] apm-mongoclient-plugin
- [ ] apm-mule4-plugin
- [ ] apm-netty-plugin
- [ ] apm-okhttp-plugin
- [ ] apm-opentracing-plugin
- [ ] apm-quartz-job-plugin
- [ ] apm-redis-plugin
- [ ] apm-scheduled-annotation-plugin
- [ ] apm-servlet-plugin #894
- [ ] apm-slf4j-plugin
- [ ] apm-spring-resttemplate-plugin
- [ ] apm-spring-webmvc-plugin
- [ ] apm-urlconnection-plugin
- [ ] apm-web-plugin
- [ ] Make sure that plugins added in the future don't instrument non-supported versions by accident #896

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.