elastic / elastic/apm-agent-java

Remove `classes_excluded_from_instrumentation_default`?

Open
#2,089 1 comment 0 reactions 0 assignees View on GitHub
agent-java discuss
Dominant language
Java
Stars
594
Forks
338
Avg merge
1d 13h
Merged PRs (30d)
25

Description

I think `classes_excluded_from_instrumentation_default` does more harm than good. It doesn’t seem to reduce the startup overhead and it can lead to surprises when trying to instrument something that has been globally excluded.

Let's remove it if there are no objections.

See https://github.com/elastic/apm-agent-java/pull/1920#issuecomment-905519224 and https://github.com/elastic/apm-agent-java/pull/1920#issuecomment-906475452 for more details.

Relates to #1920

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.