elastic / elastic/ai-github-actions
[workflow-patrol] Workflow drift detected: log-searching-agent missing standard guardrail frontmatter
- Dominant language
- Python
- Stars
- 11
- Forks
- 16
- Avg merge
- 22h 9m
- Merged PRs (30d)
- 31
Description
## Findings
### 1. `gh-aw-log-searching-agent` is missing standard guardrail frontmatter used by most comparable workflows
`gh-aw-log-searching-agent` imports the create-issue safe-output fragment and is a `workflow_call` workflow, but it omits several guardrail fields that the clear majority of comparable workflows include.
**Workflows that deviate**
- `.github/workflows/gh-aw-log-searching-agent.md`
**Majority pattern (comparable peers)**
- Among all `workflow_call` workflows (`54` total), these fields are present in:
- `on.stale-check`: `53/54` (98%)
- `on.workflow_call.inputs.report-failure-as-issue`: `53/54` (98%)
- `tools.github.min-integrity`: `49/54` (91%)
- `tools.github.trusted-users`: `49/54` (91%)
- Example workflows following the pattern:
- `.github/workflows/gh-aw-bug-hunter.md:22,55,74,75`
- `.github/workflows/gh-aw-branch-actions-detective.md:18,51,69,70`
- `.github/workflows/gh-aw-stale-issues-investigator.md:20,58,76,77`
**What is different**
- `.github/workflows/gh-aw-log-searching-agent.md` has:
- `on.workflow_call` (`:18-19`) and create-issue import (`:12`), but **no** `on.stale-check`.
- No `report-failure-as-issue` input in `on.workflow_call.inputs` (`:19-69`).
- `tools.github.toolsets` only (`:86-88`), with **no** `min-integrity` or `trusted-users`.
This looks like structural drift, likely from landing alongside broad guardrail refactors without adopting the same fields.
**Suggested fix**
- Add to `.github/workflows/gh-aw-log-searching-agent.md` frontmatter:
- `on.stale-check: false`
- `on.workflow_call.inputs.report-failure-as-issue` (boolean, default `true`)
- `tools.github.min-integrity: approved`
- `tools.github.trusted-users: ${{ inputs.allowed-bot-users }}`
## Suggested Actions
- [ ] Add the missing guardrail frontmatter fields to `gh-aw-log-searching-agent.md`.
- [ ] Re-compile workflows (`make compile`) to ensure generated artifacts remain consistent.
- [ ] Run lint checks to confirm no schema or workflow validation regressions.
## Notes
- `/tmp/previous-findings.json` is empty in this run, so no prior agent-filed duplicates were listed.
- Open `[workflow-patrol]` issue lookup was attempted, but read-path output was integrity-filtered in this runtime, so explicit duplicate confirmation could not be completed here.
> Generated by [Internal: Workflow Patrol](https://github.com/elastic/ai-github-actions/actions/runs/34848726017) · gpt53codex · 120.4 AIC · ⌖ 3.96 AIC · ⊞ 23.5K · [◷](https://github.com/search?q=repo%3Aelastic%2Fai-github-actions+is%3Aissue+%22gh-aw-workflow-call-id%3A+elastic%2Fai-github-actions%2Fworkflow-patrol%22&type=issues)
> - [x] expires on Sep 21, 2026, 1:33 PM UTC
Contributor guide
Research direction
Open .github/workflows/gh-aw-log-searching-agent.md and compare its frontmatter with the cited comparable workflows, especially gh-aw-bug-hunter.md. Add the four listed guardrail fields, then run `make compile` and the repository lint checks. Done means the workflow includes the standard fields and compilation and validation complete without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100