eic / eic/epic

Barrel ECal: Implement full frames for the AstroPix slots

Open
#607 0 comments 0 reactions 0 assignees View on GitHub
help wanted topic: calorimetry topic: geometry
Dominant language
C++
Stars
31
Forks
61
Avg merge
3d 12h
Merged PRs (30d)
16

Description

**Is your feature request related to a problem? Please describe.**

AstroPix frames do not have vertical walls in the current implementation, only horizontal.

**Describe the solution you'd like**

Implement frames as 2 trapezoids, one make of carbon fiber, second filled with air placed inside the first one and smaller of `EcalBarrel_CarbonThickness`. Then the staves need to be placed inside the second air-filled trapezoid. Something like that was done by @Chao1009 in this version of the `barrel_interlayers.xml`: https://github.com/eic/epic/commit/e1cee1f0b2176d8a0d47c07cdac63beb74bf59bb, but then it was changed to the top and bottom part of the frame only.

**Describe alternatives you've considered**
No alternatives

**Additional context**
See the illustration below:

![Illustration of the vertical parts of the frames](https://github.com/eic/epic/assets/33816222/76fe4566-28e5-4bee-91ba-1229e7436ac2)

Contributor guide

Open the contributing guide

Research direction

Start by inspecting barrel_interlayers.xml and the AstroPix slot and stave geometry it references. Compare the earlier implementation in commit e1cee1f0b2176d8a0d47c07cdac63beb74bf59b; done means the frames have the requested vertical trapezoidal carbon-fiber and air parts, with staves placed inside the inner air trapezoid.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, xml
Domain
computer-graphics, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.