eic / eic/epic

Avoid creating repetitive logical volumes for sampling calorimeters

Open
#537 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue help wanted topic: simulation
Dominant language
C++
Stars
31
Forks
61
Avg merge
3d 12h
Merged PRs (30d)
16

Description

Ideally, you create the logical layer volume once and place it several times. The flow would be:
- Create logical layer volume
- Loop over slices
- Create logical slice volume
- Place logical slice volume inside logical layer volume
- Loop over layers
- Place logical layer volume in the logical envelope volume
- Place logical envelope volume in the detector's mother volume

_Originally posted by @veprbl in https://github.com/eic/epic/pull/534#discussion_r1336283082_

Files affected
- [ ] src/InsertCalorimeter_geo.cpp
- [ ] src/EndcapCalorimeterWithInsertCutout_geo.cpp
- [ ] src/ZeroDegreeCalorimeterSiPMonTile_geo.cpp

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.