eic / eic/eic-smear

TreeToHepMC confuses milibarn and microbarn

Open
#26 1 comment 0 reactions 1 assignee Claimed by @kkauder View on GitHub
bug topic: simulation
Dominant language
C++
Stars
2
Forks
13
PR merge metrics
No merged PRs in 30d

Description

### Environment: (where does this bug occur, have you tried other environments)
All

### Steps to reproduce: (give a step by step account of how to trigger the bug)
1. Convert a EicTree root file to HepMC using TreeToHepMC

### Expected Result: (what do you expect when you execute the steps above)
crossSection gets converted from microbarn to HepMC's standard picobarn

### Actual Result: (what do you get when you execute the steps above)
TreeToHepMC false assumes that the input crossSection is in milibarn, and is thus wrong by a factor of 1000

Offending code: https://github.com/eic/eic-smear/blob/master/src/erhic/TreeToHepMC.cxx#L130-L153

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.