eic / eic/EDM4eic

Proposal for Waveform and Raw HGCROC Hit

Open
#89 6 comments 0 reactions 1 assignee Claimed by @ruse-traveler View on GitHub
Dominant language
C++
Stars
4
Forks
7
Avg merge
1d 8h
Merged PRs (30d)
3

Description

![PXL_20240725_235606610](https://github.com/user-attachments/assets/897cc527-f1e5-47db-95d6-ee5451902eac)

One of the items discussed during the [July 2024 ePIC Collaboration Meeting](https://indico.bnl.gov/event/20727/sessions/7437/#20240725) was the steps needed to better simulate the HGCROC. One thing identified was the need to make sure we have the data types necessary to capture both the waveform produced by a SiPM as well as the output of the HGCROC.

**Describe the solution you'd like**

For the waveform, we could make use of `edm4hep::RawTimeSeries` (from [here](https://github.com/key4hep/EDM4hep/blob/a173bdec749abf5447810b25286a64456914faa6/edm4hep.yaml#L510)).:

```
edm4hep::RawTimeSeries:
Description: "Raw data of a detector readout"
Author: "EDM4hep authors"
Members:
- uint64_t cellID // detector specific cell id
- int32_t quality // quality flag for the hit
- float time [ns] // time of the hit
- float charge [fC] // integrated charge of the hit
- float interval [ns] // interval of each sampling
VectorMembers:
- int32_t adcCounts // raw data (32-bit) word at i
```

But for the HGCROC output, we would need to extend what's already in `edm4hep::RawCalorimeterHit`. For example:

```
edm4eic::RawHGCROCHit:
Description: "Raw hit from an HGCROC"
Author: "H. G. Croc"
Members:
- uint64_t cellID // detector specific (geometrical) cell id
- int32_t timeOfArrival // ToA value [adc counts]
- int32_t timeOverThreshold // ToT value [adc counts]
- int32_t amplitude // amplitude of hit [adc counts]
- int32_t timeSamp // time stamp for the hit
```

**Describe alternatives you've considered**

One alternate approach could be to save only one of the values from the HGCROC (e.g. amplitude) in `edm4hep::RawCalorimeterHit`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.