egoist / egoist/tsup

Upgrading from 5.12.9 to 6.0.0 makes the msw test suite segfault

Open
#919 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
275
PR merge metrics
No merged PRs in 30d

Description

Steps to reproduce:
1. `git clone git@github.com:mswjs/msw.git`
2. `cd msw`
3. `pnpm i`
4. `pnpm build ; pnpm test:node` and all should go well
6. `pnpm i tsup@6.0.0` (or any later version)
7. `pnpm build ; pnpm test:node` and the node process segfaults:
```
...
PASS test/node/msw-api/auto-update-worker.node.test.ts (10.655 s)
PASS test/node/msw-api/cli/init.node.test.ts
PASS test/node/msw-api/setup-server/life-cycle-events/on.node.test.ts
PASS test/node/msw-api/setup-server/resetHandlers.node.test.ts
PASS test/node/msw-api/context/delay.node.test.ts
PASS test/node/msw-api/setup-server/scenarios/on-unhandled-request/callback.node.test.ts
PASS test/node/msw-api/setup-server/scenarios/on-unhandled-request/warn.node.test.ts
PASS test/node/msw-api/setup-server/scenarios/fall-through.node.test.ts
PASS test/node/msw-api/setup-server/scenarios/on-unhandled-request/default.node.test.ts
PASS test/node/rest-api/request/matching/all.node.test.ts

RUNS test/node/graphql-api/response-patching.node.test.ts
[1] 3794 segmentation fault pnpm test:node
```

Discovered in https://github.com/mswjs/msw/pull/1633

Contributor guide

Open the contributing guide

Research direction

Reproduce in the msw repository with pnpm i, pnpm build, and pnpm test:node, then compare tsup 5.12.9 with 6.0.0 or later. Start with the failing test run around test/node/graphql-api/response-patching.node.test.ts; done means the Node test suite no longer segfaults after upgrading tsup.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.