egoist / egoist/tsup

buildEnd on tsup plugin is called before dts files are generated

Open
#799 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.3k
Forks
275
PR merge metrics
No merged PRs in 30d

Description

I was playing around with a custom tsup plugin (not esbuild plugin!) and found out that apparently, the buildEnd hook is called after bundling is done, but before the .d.ts files are generated (with `dts = true`). I would have expected that hook to be called when all build steps are done. Not sure if this is intended behaviour or not, but it was definitely surprising for me.
I would suggest either to call buildEnd _after_ the dts files are generated, or to introduce a new hook that behaves this way.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.