egoist / egoist/bundle-require

Latest esbuild removes watch flag in build option

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
185
Forks
19
PR merge metrics
No merged PRs in 30d

Description

According to [release notes of v0.17.0](https://github.com/evanw/esbuild/releases/tag/v0.17.0), `watch` option is removed and it cause `bundle-require` to error:

```
✘ [ERROR] Invalid option in build() call: "watch"

/Users/otakustay/Develop/reskript/node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:255:12:
255 │ throw new Error(`Invalid option ${where}: ${quote(key)}`);
╵ ^

at checkForInvalidFlags (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:255:13)
at flagsForBuildOptions (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:457:3)
at buildOrContextContinue (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:1009:9)
at .node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:983:11
```

To be compatible with multiple version of esbuild, maybe we can make a new option, allow users to pass `esbuild.build` function directly?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.