eggjs / eggjs/egg

Origin request header and Access-Control-Allow-Origin

Open
#3,765 1 comment 0 reactions 0 assignees View on GitHub
Inactive PR is welcome
Dominant language
TypeScript
Stars
19k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#Examples

> Limiting the possible Access-Control-Allow-Origin values to a set of allowed origins **requires code on the server side to check the value of the Origin request header, compare that to a list of allowed origins, and then if the Origin value is in the list, to set the Access-Control-Allow-Origin value to the same value as the Origin value.**

But https://github.com/eggjs/egg-cors just set `Access-Control-Allow-Origin` and don't compare `Origin` header

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.