effekt-lang / effekt-lang/effekt
Rename 'compare$Type' to '$Type::compare'
- Dominant language
- Scala
- Stars
- 469
- Forks
- 41
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 23
Description
As of #1427, 'map' and 'set' are also searching for an implicit 'compare' function.
After #1435 is merged, it might be a good idea to rename all 'compare$Type' functions to '$Type::compare' so that nobody needs to pass an explicit compare function anymore for the common cases at least :)
That said, this will likely be a non-trivial breakage in the community build, so whoever does this also needs to prepare the PRs there.
Beware: do _not_ rename the 'genericCompare' function :)
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing issues #1427 and #1435, then locate all compare$Type functions and verify which references require renaming. Keep genericCompare unchanged, update the affected community-build PRs, and confirm that common map and set cases no longer need explicit compare functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100