effekt-lang / effekt-lang/effekt

Inconsistent handling of line endings on Windows vs Linux

Open
#1,183 0 comments 1 reaction 0 assignees View on GitHub
area:parser/lexer windows
Dominant language
Scala
Stars
469
Forks
41
Avg merge
1d 16h
Merged PRs (30d)
23

Description

Currently 35 tests on Windows fail.

Git converts all line endings of text to CRLF on Windows (default git behavior).
Using the git config `core.autocrlf=false` will fix most of the tests.
Adding a .gitattributes with `* text eol=lf` should work for everyone, although it would hide the underlying issue.

Many errors stem from some incorrect handling in the Lexer, e.g. here:
https://github.com/effekt-lang/effekt/blob/a4c916fa3506db9899bc4387bdba14c8fee3578f/effekt/shared/src/main/scala/effekt/Lexer.scala#L627

Other errors come from string literal comparisons that fail, since the tests only expects '\n'.

As stated, there are a total of 35 tests that are failing and i am willing to share more insights and even fix them, when needed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.