eellak / eellak/commit-timeline

Scripts ignore GitHub API's pagination/rate limits, contain half of the work

Open
#1 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
2
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The scripts are very naive: trying to consume a RESTful API with bash/curl isn't exactly a sound idea IMHO :)

For starters, greek-commiters.sh curls for followers/location, but ignores the fact that the results are rate limited and paginated. So, for example, followers>5 + Athens alone has 187 results (and "Athens, Greece" 144) , but the first API call (without a ?page= argument) returns 30 and the total users.txt has only 90 people. You're essentially missing half of your target set…

Moreover, just search for "Athens" isn't enough -- there's also an Athens in the state of Georgia in the United States; your result set includes users that have e.g. "Athens, GA" in their profile (for example, user "yegle"). The complete result set will have other permuations of that ("Athens, Georgia") as well as inconclusive results ("Athens"). Maybe you should only search for "Athens, Greece".

In general, I'd suggest something slightly more sophisticated, in a higher level language.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.