editor-js / editor-js/embed

Urls over a set length won't work

Open
#33 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
159
Forks
105
PR merge metrics
No merged PRs in 30d

Description

I'm tríing to get embed to work but I noticed that some urls won't work. I think it has something to do with url length. For reproduction of the issue use following config and Uel:

embed:
{
class: Embed,
inlineToolbar: itb,
config:
{
services:
{
falstad:
{
regex: /https?:\/\/(www\.)?falstad.com\/circuit\/circuitjs.html\?ctz=(.*)/,
embedUrl: 'https://www.falstad.com/circuit/circuitjs.html?ctz=<%= remote_id %>',
html: "",
height: 400,
width: 800,
id: (groups) => groups[1]
},
}
}
},

http://www.falstad.com/circuit/circuitjs.html?ctz=CQAgjCAMB0l3BWcMBMcUHYMGZIA4UA2ATmIxAUgpABZsAoANxAFowU8RcbX3Ox2UcBSpIq46AnoATVnioCUtfoKXSApgDMAhgFcANgBd6AJxDFC4QRa6QeCuPQDuchYLYcrSyM+VfzlopQvjbcvJ5hPswoCJZhMYGCCiLU4lCSMlx4PCgoPNjZ-mpaekaZ2NhxdlyVIGicxToGxrIVlvU1iUqNpS1Z+dUFOXl1IBpNZS5t-kP+PlO1YbORvglFeCreqxvrDfjBLhx7nNMd83Wxtjk7K4c31Ud1I+ePufmFbwf9-jQ2QefLaq-Kr2UwUGg8IIICFXIRgRw0SDYVg0fgYSzyOqIoQoAD6hBouMguMRpFxCCJsApxLxeIYiORiIU6IonjyaRQYHxhOJpOI5MpkGpuNpXIYLmhkMEwLmvklsJlKyAA

Halfway through the url it works well (meaning it will properly insert the iframe with the incomplete link) but the while url does not insert the embed iframe.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.