editor-bootstrap / editor-bootstrap/emacs-bootstrap

Avoid overriding global key bindings

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
169
Forks
22
PR merge metrics
No merged PRs in 30d

Description

It looks some of the key-bindings that you've made are overriding the default key bindings set by emacs. Some time ago, I had a lengthy discussion about the same issue [here](https://emacs.stackexchange.com/questions/27926/avoiding-overwriting-global-key-bindings). I came into the conclusion to use `C-c` prefix for most of my user defined key bindings so that they don't override with any default key bindings.

From my quick check here are some key bindings that are overriding the default key bindings:
* swiper `C-x s` -> this key binding is bound to `save-from-buffers` (I use this command a lot)
* counsel-projectile `C-x v` -> This is the version control prefix
* ivy-resume `C-x C-r` -> This is bound to `find-file-read-only` (why does this key binding exist? `ivy-reusme` by default is bound to `C-c C-r`, which is fine as is)
* **All** the key bindgings that begin with prefix `C-x c` -> this overrides default binding for `calc-mode`

My suggestion would be to prefix user defined key bindings with `C-c` instead of `C-x`, so that we don't accidentally override any key bindings. It might be fine now, but as the user start assigning more bindings to commands, he'll quickly run out of `C-x` prefixes which aren't bound to any command.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.