edgurgel / edgurgel/solid

break and continue with whitespace control issue

Open
#86 2 comments 0 reactions 0 assignees View on GitHub
bug hacktoberfest
Dominant language
Elixir
Stars
259
Forks
58
Avg merge
9d 18h
Merged PRs (30d)
2

Description

```
Render result was different!
Input:
########################

this should print

{%- break -%}

this should not print

########################

code: liquid_output == solid_output
left: "########################\n\nthis should print\n"
right: "########################\n\nthis should print"
```

```
Render result was different!
Input:
########################

this should print

{%- continue %}

this should not print

########################

code: liquid_output == solid_output
left: "########################\n\nthis should print\n"
right: "########################\n\nthis should print"
```

https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/break_tag_test.exs#L3-L15
& https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/continue_tag_test.exs#L3-L15

Contributor guide

Open the contributing guide

Research direction

Start with test/integration/whitespace_control_cases/break_tag_test.exs and continue_tag_test.exs, then trace the implementation used by these whitespace-control cases. Run the two tests to reproduce the missing trailing newline for break and continue. Done means both cases produce the expected rendered output.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.