edgurgel / edgurgel/httpoison

why no_proxy doesn't support CIDR range format?

Open
#450 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Elixir
Stars
2.3k
Forks
349
PR merge metrics
No merged PRs in 30d

Description

I saw the source code https://github.com/edgurgel/httpoison/blob/65e94a9ed8e1443e99cd715c2068871feba1f50a/lib/httpoison/base.ex#L816, no_proxy only support for wildcard format (10.0.. or 10.0. ) but doesn't support cidr range format like 10.0.0.0/16. Is there any concern about implementing it like Golang?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/httpoison/base.ex around line 816 and inspect how no_proxy currently matches wildcard formats. Compare the requested 10.0.0.0/16 behavior with the referenced Go behavior, then determine the expected handling for CIDR ranges and verify that both existing wildcard matching and CIDR matching work correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.