ecosyste-ms / ecosyste-ms/diff

The diff's `zipnote` may need re-ordering

Open
#442 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
7
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When looking at an example diff https://diff.ecosyste.ms/diff?url_1=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.0.0.zip&url_2=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.1.0.zip I see:

```diff
-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/ci.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/release-drafter.yml
Comment:

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/generate.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/ci.yml
Comment:

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/lint.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/generate.yml
Comment:

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/tidy.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/lint.yml
Comment:
```

In these cases, the only changes between them are the versions, but we're seeing some of the orders being wrong - maybe we need to recursively sort the filenames before `diff`ing them?

## Upvote & Fund

- We're using [Polar.sh](https://polar.sh/ecosyste-ms) so you can upvote and help fund this issue.
- We receive the funding once the issue is completed & confirmed by you.
- Thank you in advance for helping prioritize & fund our backlog.


Fund with Polar

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.