ecolistening / ecolistening/SoundADE

[TASK] Clarify purpose of various filtering functions in `prefilter.py`

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
dac-paper question
Dominant language
Python
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

It's not clear what the following line of code is for:

https://github.com/ecolistening/SoundADE/blob/f4a8655a0c8a3228550b9e5c5a0fc6a0ec9d2fcd/scripts/prefilter.py#L84

It's also not clear why we use `days_with_too_few_points` twice, using `date` as `agg_columns` argument in the first instance and `recorders` in the second.

We need to ask @dkadish, but should probably collect other questions first.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.