eclipsesource / eclipsesource/tabris-js

Video controls never shown when controlsVisible is false

Open
#2,289 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
1.4k
Forks
171
PR merge metrics
No merged PRs in 30d

Description

### Problem description

Previously, when `controlsVisible` was `false`, the controls appeared in an overlay when the user tapped on the video. In Tabris.js 3.9.0, the controls don't appear anymore upon tap. In the snippet below, tapping on the very center of the video pauses it though, which indicates that the controls are interactive, despite being invisible.

### Expected behavior

When `controlsVisible` is `false`, either:
- the video controls should appear when the video is tapped, or:
- the user should not be able to interact with invisible video controls

### Environment

- Tabris.js version: 3.9.0
- Device: iPhone
- OS: 17.3.1

### Code snippet

```js
import {Button, contentView, Video} from 'tabris';

const button = new Button({
id: 'button',
centerX: 0, bottom: 16,
text: '❚❚'
}).onSelect(() => video.state === 'play' ? video.pause() : video.play())
.appendTo(contentView);

const video = new Video({
left: 0, top: 0, right: 0, bottom: '#button 16',
url: 'http://peach.themazzone.com/durian/movies/sintel-1280-stereo.mp4',
controlsVisible: false
}).onStateChanged(({value: state}) => button.text = state !== 'pause' && state !== 'finish' ? '❚❚' : '▶')
.appendTo(contentView);

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.