eclipsesource / eclipsesource/jsonforms

Increase strictness of `tsconfig`

Open
#2,255 1 comment 0 reactions 0 assignees View on GitHub
dev help wanted
Dominant language
TypeScript
Stars
2.7k
Forks
424
Avg merge
17d 8h
Merged PRs (30d)
1

Description

### Is your feature request related to a problem? Please describe.

Currently `tsconfig.base.json` has quite low strictness, and Typescript is not helping the developer as much as it could.

Also, there is a higher change of bugs arising without this strictness.

I suggest `"strict": true` and `"noUncheckedIndexedAccess": true` is added to `tsconfig`, but there are also some other settings that could be interesting.

Matt Pocock has a good blog post here: [https://www.totaltypescript.com/tsconfig-cheat-sheet](https://www.totaltypescript.com/tsconfig-cheat-sheet).

In case this is something that could be added, we should start by updating `@jsonforms/core` and could afterwards do other packages.

It would require quite a bit of (small) changes several places.

### Describe the solution you'd like

`packages/core/tsconfig.json`:
```jsonc
{
"compilerOptions": {
"verbatimModuleSyntax": true,
/* strictness */
"strict": true,
"noUncheckedIndexedAccess": true,
}
}
```

see also:
- [strict](https://www.typescriptlang.org/tsconfig#strict)
- [noUncheckedIndexedAccess](https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess)

### Describe alternatives you've considered

.

### Framework

Core

### RendererSet

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.