eclipsesource / eclipsesource/jsonforms

Child errors of arrays do consider childrens' i18n keys

Open
#2,126 0 comments 0 reactions 0 assignees View on GitHub
core
Dominant language
TypeScript
Stars
2.7k
Forks
424
Avg merge
17d 8h
Merged PRs (30d)
1

Description

### Describe the bug

The `mapStateToArrayLayoutProps` does not consider child UI schema's i18n keys when calculating the array's child errors.

Noticed via: https://jsonforms.discourse.group/t/how-to-handle-rollup-errors-with-a-control-using-i18n/1422

### Expected behavior

The method `getCombinedErrorMessage` used in `mapStateToArrayLayoutProps` should resolve provided i18n messages for errors in child elements.

### Steps to reproduce the issue

1. Use an array control with object array elements and customize error messages for the child UI schema
2. create errors
3. Hover over the array's error aggregation tooltip to see the untranslated error messages

### Which Version of JSON Forms are you using?

latest commit from Mar 15, 2023

### Framework

Core

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.