eclipsesource / eclipsesource/jsonforms
Investigate mapStateToArrayLayoutProps and mapStateToArrayControlProps usage
Open
core
refactoring
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 424
- Avg merge
- 17d 8h
- Merged PRs (30d)
- 1
Description
There are two types of props for array types: `ArrayLayoutProps` and `ArrayControlProps`. At a first glance, one of them seems redundant.
`mapStateToArrayLayoutProps` has some extra handling of the validation errors to easier display them in the UI and `mapStateToArrayControlProps` passes the renderers and cells from the ownProps if they are available (the fact that this is missing from `mapStateToArrayLayoutProps` is probably a bug).
We should investigate if we can merge the two types of props into one and clean up the code.
Contributor guide
Assessment
This issue has not been assessed yet.