eclipsesource / eclipsesource/jsonforms

Changes in the examples source are not picked up correctly

Open
#1,104 1 comment 0 reactions 0 assignees View on GitHub
dev
Dominant language
TypeScript
Stars
2.7k
Forks
424
Avg merge
17d 8h
Merged PRs (30d)
1

Description

**Describe the bug**
When I change a schema for an example a rebuild is triggered but the change is not actually picked up.
This is probably because in index.tsx the import of the examples should be changed to:
import { getExamples } from '../../examples/src';
When I do that it basically works but now the full page will reload which resets the currently selected example in the drop-down. This makes the examples unusable for a demo.

**To Reproduce**
Run material examples: cd packages/material && npm run dev

**Expected behavior**
A build is triggered but the page does not fully reload so the last examples stays selected. Alternatively the examples app could remember the last selected example

**Additional context**
If a fix is more expensive than 4 hours, let us reconsider.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.