eclipsesource / eclipsesource/J2V8
Memory manager should not use `.equals` to compare objects
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 387
- PR merge metrics
- No merged PRs in 30d
Description
The `MemoryManager` is using a `List` which ultimately means that `.equals` is being used to compare values in methods such as `persist`. Instead, we should use an Array or some structure that uses `==` to compare values. This is because two Objects that are created, much be released independently, regardless if they are `.equals()` or not.
Contributor guide
Research direction
Locate the MemoryManager implementation and inspect persist and the other methods that compare or release objects. Trace how the List is used and identify the existing lifecycle behavior for distinct but equal objects. Done means object tracking and release use identity rather than equality, with coverage for independently releasing equal objects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100