eclipsesource / eclipsesource/J2V8
Support for Set in V8ObjectUtils?
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 387
- PR merge metrics
- No merged PRs in 30d
Description
As we are noticing our backend serialized Sets as model which we then convert to V8Objects. Standard implementation of V8ObjectUtils does not understand Sets.
At the moment we copied V8ObjectUtils and adopted it to understand sets including a SetWrapper object.
We could open this as PR but not sure if this matches with strategy where maintainers of this project would like to go. After all converting set to a list in v8 is discussable decision...
One option could be also do to some refactoring that one could decide on how to convert. Some people communicated here that they go first through GSON and then throw GSON serialized model to V8ObjectUtils. This of course has performance implications but could work as well. GSON has then TypeAdapters to JSON, etc.
Thoughts?
Contributor guide
Assessment
This issue has not been assessed yet.