eclipse-xtext / eclipse-xtext/xtext
Generated textmate grammar highlights punctuation characters as invalid
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
A textmate grammar generated by the TextMateHighlightingFragment does not contain a rule for punctuation. As a result, any punctuation characters are picked up by the invalid rule and highlighted accordingly.
I've looked at the code and basically every keyword that does not match \w+ is ignored here and will then be picked up by the invalid rule.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in TextMateGrammar.java around line 176, then read TextMateHighlightingFragment.java to understand how the grammar is generated. Verify how non-word keywords are handled and confirm that generated punctuation is currently matched by the invalid rule. Done means generated grammars handle punctuation without highlighting it as invalid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100