eclipse-xtext / eclipse-xtext/xtext
PartialClassExtractor can handle newlines wrong
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
If the CodeConfig defines a lineDelimiter that is different than the system one, then org.eclipse.xtext.xtext.generator.parser.antlr.splitting.PartialClassExtractor fails to do extractions, because it assumes the files it works on were generated using system line breaks.
I guess a fix would be to pass the CodeConfig or the delimiter itself into the PartialClassExtractor constructor and use the delimiter instead of Strings.newLine().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with org.eclipse.xtext.xtext.generator.parser.antlr.splitting.PartialClassExtractor and inspect how its constructor and extraction logic use Strings.newLine(). Trace the CodeConfig lineDelimiter into this path, then verify that extraction succeeds when it differs from the system line separator.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- compilers, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100