eclipse-xtext / eclipse-xtext/xtext
Rename refactoring takes the first occurance - even in comment - to start linked-editing
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
// MyClass
class MyClass { ...
Starting renaming of MyClass will start the renaming in the comment.
org.eclipse.xtext.ui.refactoring2.rename.DefaultLinkedPositionGroupCalculator2.createLinkedGroupFromReplaceEdits(List, XtextEditor, String, SubMonitor)
This takes the whole text of the "class", which is inclusive the comment. Then searches in there for "MyClass" and finds the position of the comment as the first (and only) result position.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at org.eclipse.xtext.ui.refactoring2.rename.DefaultLinkedPositionGroupCalculator2.createLinkedGroupFromReplaceEdits(List, XtextEditor, String, SubMonitor) and reproduce the issue with the provided class declaration and comment. Trace how the whole class text is searched for MyClass; done means rename linked-editing begins at the declaration rather than the comment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100