eclipse-xtext / eclipse-xtext/xtext

[Generator][SemanticSequencer] Dead Assignments

Open
#2,575 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

Depending on the situation, Xtext will create dead assigments inside the generated SemanticSequencer.

e.g.

@Override
	public void sequence(ISerializationContext context, EObject semanticObject) {
		EPackage epackage = semanticObject.eClass().getEPackage();
		ParserRule rule = context.getParserRule();
		Action action = context.getAssignedAction();
		Set<Parameter> parameters = context.getEnabledBooleanParameters();
                ....

in this case rule, action and parameters are unused.

Example Grammar

MyRoot:
	r1=Root1 | r2=Root2
;

Root1:
	"root1" name=ID
;

Root2:
	"root2" name=ID
;

or

MyRoot:
	r1=Root1
;

Root1:
	"root1" name=ID
;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the generated SemanticSequencer output described in the issue and reproduce the examples using the provided grammars. Trace the generator path that emits sequence(...) and identify when rule, action, and parameters are unused. Done means generated sequencers no longer contain dead assignments for these cases, with coverage for both example grammars.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.