eclipse-xtext / eclipse-xtext/xtext

Serializer skips tokens

Open
#2,477 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

Inside https://github.com/eclipse/xtext-eclipse/pull/1586/files (search for "CopyFieldNameToVariableStmt") it was found that the serializer seems to skip some tokens where it is unknown why it does so.

Serializing

CopyFieldNameToVariableStmt:
  'FIELD-NAME-TO-VARIABLE' ((',' 'SCREEN' '=' '(' line=INT ',' column=INT ')') &
                            (',' 'VAR' '=' name=ID) &
                            (',' 'TYPE' '=' 'REPLACE')?);

seems to remove a "(" for unknown reason.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the files changed in pull request #1586 and search for CopyFieldNameToVariableStmt. Reproduce serialization of the shown grammar and compare the input and output around the opening parenthesis. Done means identifying why the token is skipped and confirming that serialization preserves it.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.