eclipse-xtext / eclipse-xtext/xtext

Optimize the usage of the IResourceSetupUtil.addNature(IProject project, String nature) method.

Open
#2,440 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

The Xtext Ui Test Infrastructure makes heavy usage of the IResourcesSetupUtil.addNature method
https://github.com/eclipse/xtext-eclipse/blob/07a503f99c1b867f2d52ea9b02f7019d022912a2/org.eclipse.xtext.ui.testing/src/org/eclipse/xtext/ui/testing/util/IResourcesSetupUtil.java#L78-L88.

Since this call could slow down the test execution when called much more times than actually needed, it should be investigate how to optimize this.

See also TODO statement
https://github.com/eclipse/xtext-eclipse/blob/07a503f99c1b867f2d52ea9b02f7019d022912a2/org.eclipse.xtext.ui.testing/src/org/eclipse/xtext/ui/testing/AbstractHighlightingTest.xtend#L90-L97

and comment.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.