eclipse-xtext / eclipse-xtext/xtext

Rename Refactoring is order dependent

Open
#2,403 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

Using

Model: {Model}
    elements+=Element*
    refs+=Ref*
;

Element:
    'element' name=ID
;

Ref:
    "ref" ref=[Element]
;   

and

element A 
element B 
ref A 
ref B

refactoring behaves differently if i rename A to B or i rename B to A.

since the scoping behaviour behind this is intended https://github.com/eclipse/xtext-core/issues/152 the refactoring must do the checks differently

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the grammar and the example model in the issue, then read the scoping behavior described in issue 152. Trace the rename-refactoring checks for renaming A to B and B to A; done means both rename directions behave consistently with the intended scoping behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.