eclipse-xtext / eclipse-xtext/xtext

TextViewerMoveLinesAction is useless in embedded editor

Open
#2,377 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

Hi.

org.eclipse.xtext.ui.editor.embedded.TextViewerMoveLinesAction implements the method runWithEvent(Event).
However org.eclipse.xtext.ui.editor.embedded.ActivationCodeTrigger calls IAction.run(), when an activation code match is found.
In TextViewerMoveLinesAction the run() method does nothing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with org.eclipse.xtext.ui.editor.embedded.TextViewerMoveLinesAction and inspect its runWithEvent(Event) implementation alongside ActivationCodeTrigger, which calls IAction.run(). Confirm the embedded editor path and existing action behavior, then make the action respond correctly when run() is invoked. Verify the move-lines action through the relevant embedded-editor tests, if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.