eclipse-xtext / eclipse-xtext/xtext

Simplify precedure when updating ASM dependency

Open
#2,352 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new_feature technical_debt
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

Currently we have a rather strict dependency on a narrow range of ASM versions and use OpCodes.ASM.. in our code at different places.
Subject to discussion:
We could widen the range and introduce AsmOpCodes.latest() that uses

  • reflection
  • a feature flag / preference
  • or is at least only to to be changed at a single location

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the current ASM dependency declaration and the uses of OpCodes.ASM.. in the codebase. Decide on the supported-version and centralization approach, then verify dependency compatibility and all affected usages; the issue provides no named test or file.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.