eclipse-xtext / eclipse-xtext/xtext

Validation of JUnit test methods too restrictive

Open
#2,335 6 comments 0 reactions 1 assignee View on GitHub

@sailingKieler is already working on this.

Since Dec 12, 2019.

enhancement
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

The validation of JUnit-based test methods contributed by eclipse/xtext-xtend#488 and refined in eclipse/xtext-xtend#528 is too restrictive broke various tests being run by means of specific test runners.

I propose to exclude JUnit4 tests being run via custom runners, i.e. those runner implementations with their declared package not starting with org.junit. AFAICS applying the validation for JUnit5 tests is fine, as JUnit5 offers different means for creating tests at runtime.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.