Compiler picks wrong `it` to access an external property inside an anonymous class when mapping a list

class Test {
  static class Thing {
    var Object property
  }

  def test(List<Object> objects) {
    objects.map [
      new Thing => [
        property = new Object() {
          val oldValue = property // Java error
        }
      ]
    ]
  }
}

The 2.28.0.v20220829-0536 compiler produced invalid Java for this by selecting the wrong it for the access to property inside the anonymous object.

It is worth mentioning that the issue is only present when objects is a List and the transformation is a map, so somehow the logic breaks due to some difference between the implementations of map in IterableExtensions and ListExtensions.

The issue can be avoided by explicitly defining the lambda variable it for the arrow operator's lambda: => [it|...]

There is no linking error in either case.

May be related to eclipse/xtext-xtend#1301.

Start with the supplied Test reproducer and inspect how the compiler resolves it for the nested lambdas. Compare the map paths in IterableExtensions and ListExtensions, which the issue identifies as differing. Done means the List/map case selects the external property correctly and produces valid Java without requiring an explicit lambda variable.