eclipse-xtext / eclipse-xtext/xtext

Renaming a constant uses the fully qualified name unnecessarily

Open
#2,294 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug confirmed
Dominant language
Java
Stars
831
Forks
330
Avg merge
3d 7h
Merged PRs (30d)
12

Description

If I rename a constant field in a xtend class it will refactor the source to use the FQN of that field even when it's not necessary.

Example:

package hello

class HelloWorld {
    
    static val MESSAGE = 'Hello World'
    
    def static main(String[] args) {
        println(MESSAGE)
    }
    
}

If I refactor MESSAGE to TEST the result is:

package hello

class HelloWorld {
    
    static val TEST = 'Hello World'
    
    def static main(String[] args) {
        println(hello.HelloWorld.TEST)
    }
    
}

The expected result is:

package hello

class HelloWorld {
    
    static val TEST = 'Hello World'
    
    def static main(String[] args) {
        println(TEST)
    }
    
}

Live demo:

refactor_constant

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file or test. Start by reproducing the constant-rename example in an Xtend class, then trace the rename refactoring entry point. Done means the renamed reference remains TEST rather than becoming hello.HelloWorld.TEST.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.