eclipse-xtext / eclipse-xtext/xtext
Better code generation for toString() on primitives
Open
Nobody has claimed this yet.
confirmed
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
When using .toString() on a primitive Xtend generates BoxedPrimitive.valueOf(a).toString() instead of BoxedPrimitive.toString(a).
For example, the following Xtend:
private def void doThing() {
val int a = 0;
val String b = a.toString
}
Generates the following Java:
private void doThing() {
final int a = 0;
final String b = Integer.valueOf(a).toString(); // Should use Integer.toString(a)
}
This allocates a boxed primitive while a static function is available exactly for this purpose.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Xtend code-generation entry point for primitive .toString() calls and reproduce the issue with the example in this report. Done means the generated Java uses the primitive wrapper's static toString(a) method instead of boxing through valueOf(a).toString().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100