eclipse-xtext / eclipse-xtext/xtext
Rename Refactoring not working
Open
Nobody has claimed this yet.
bug
confirmed
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
Rename Refactoring on Foot not working (Xtext 2.11)
class Foot {
new(Bar bar) {
}
}
class Bar {
public val foo1 = new Foot(this) {
}
public val foo2 = new Foot(this) {
}
public val foo3 = new Foot(this) {
}
}
java.lang.IllegalArgumentException: JvmGenericType: (eProxyURI: platform:/resource/org.eclipse.xtext.example.domainmodel.ui/src/org/eclipse/xtext/example/domainmodel/ui/Foot.xtend#/1)
at org.eclipse.xtend.core.scoping.AbstractScope.getElements(AbstractScope.java:64)
at org.eclipse.xtext.xbase.serializer.SerializerScopeProvider$1.getElements(SerializerScopeProvider.java:119)
at org.eclipse.xtext.ui.refactoring.impl.RefactoringCrossReferenceSerializer.getCrossRefText(RefactoringCrossReferenceSerializer.java:68)
at org.eclipse.xtext.ui.refactoring.impl.DefaultReferenceUpdater.createReferenceUpdate(DefaultReferenceUpdater.java:125)
at org.eclipse.xtext.xbase.ui.jvmmodel.refactoring.JvmModelReferenceUpdater.createReferenceUpdate(JvmModelReferenceUpdater.java:50)
at org.eclipse.xtext.xbase.ui.refactoring.XbaseReferenceUpdater.createReferenceUpdate(XbaseReferenceUpdater.java:155)
at org.eclipse.xtext.ui.refactoring.impl.DefaultReferenceUpdater.createReferenceUpdate(DefaultReferenceUpdater.java:111)
at org.eclipse.xtext.ui.refactoring.impl.DefaultReferenceUpdater.processReferringResource(DefaultReferenceUpdater.java:93)
at org.eclipse.xtext.xbase.ui.refactoring.XbaseReferenceUpdater.processReferringResource(XbaseReferenceUpdater.java:237)
at org.eclipse.xtext.ui.refactoring.impl.DefaultReferenceUpdater.createReferenceUpdates(DefaultReferenceUpdater.java:78)
at org.eclipse.xtext.ui.refactoring.impl.AbstractReferenceUpdater.createReferenceUpdatesForCluster(AbstractReferenceUpdater.java:152)
at org.eclipse.xtext.ui.refactoring.impl.AbstractReferenceUpdater.createClusteredReferenceUpdates(AbstractReferenceUpdater.java:104)
at org.eclipse.xtext.ui.refactoring.impl.AbstractReferenceUpdater.createReferenceUpdates(AbstractReferenceUpdater.java:80)
at org.eclipse.xtext.ui.refactoring.impl.AbstractReferenceUpdater.createReferenceUpdates(AbstractReferenceUpdater.java:59)
at org.eclipse.xtext.ui.refactoring.impl.ReferenceUpdaterDispatcher.createReferenceUpdates(ReferenceUpdaterDispatcher.java:83)
at org.eclipse.xtext.ui.refactoring.impl.RenameElementProcessor.checkFinalConditions(RenameElementProcessor.java:262)
at org.eclipse.xtext.xbase.ui.jvmmodel.refactoring.jdt.CombinedJvmJdtRenameProcessor.checkFinalConditions(CombinedJvmJdtRenameProcessor.java:125)
at org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:222)
at org.eclipse.ltk.core.refactoring.Refactoring.checkAllConditions(Refactoring.java:162)
at org.eclipse.xtext.ui.refactoring.ui.RenameRefactoringExecuter$CheckConditionsAndCreateChangeRunnable.run(RenameRefactoringExecuter.java:144)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2267)
at org.eclipse.xtext.ui.refactoring.ui.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:83)
at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:437)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:353)
at org.eclipse.ui.internal.WorkbenchWindow$14.run(WorkbenchWindow.java:2184)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2180)
at org.eclipse.xtext.ui.refactoring.ui.RenameRefactoringExecuter.execute(RenameRefactoringExecuter.java:97)
at org.eclipse.xtext.ui.refactoring.ui.DefaultRenameSupport.startDirectRefactoring(DefaultRenameSupport.java:98)
at org.eclipse.xtext.ui.refactoring.ui.RenameRefactoringController.startDirectRefactoring(RenameRefactoringController.java:202)
at org.eclipse.xtext.ui.refactoring.ui.RenameRefactoringController.startRefactoring(RenameRefactoringController.java:115)
at org.eclipse.xtext.ui.refactoring.ui.RenameLinkedMode$EditorSynchronizer.left(RenameLinkedMode.java:167)
at org.eclipse.jface.text.link.LinkedModeModel.exit(LinkedModeModel.java:341)
at org.eclipse.jface.text.link.LinkedModeUI$3.run(LinkedModeUI.java:1185)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4032)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3708)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the rename of Foot using the Xtext example in the issue and inspect the stack beginning at RefactoringCrossReferenceSerializer.getCrossRefText and DefaultReferenceUpdater.createReferenceUpdate. Trace how the JvmGenericType proxy is handled during reference updates. Done means the rename completes without the reported IllegalArgumentException for the provided example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100