eclipse-xtext / eclipse-xtext/xtext
Accessors annotation should allow this-returning setters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Description
See eclipse/xtext-xtend#903.
Rationale: In some APIs, setters for a given type T have the signature T setField(FieldType) (instead of void setField(FieldType)) and return this. In order to comply to these API constraints for some projects, this option should also be possible to be generated by @Accessors annotation.
Proposed fix: See PR eclipse/xtext-lib#317. By default, the annotation generates void-setters. By resetting the flag Accessors.voidSetter, the alternate setter type will be generated instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Accessors annotation and compare the proposed fix in eclipse/xtext-lib#317. Verify how the voidSetter option affects generated setters, with void setters remaining the default and the alternate this-returning form available when the flag is reset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100