eclipse-vertx / eclipse-vertx/vertx-sql-client

Possibly misleading comment or bug

Open
#1,595 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
Java
Stars
912
Forks
212
Avg merge
17h 30m
Merged PRs (30d)
3

Description

### Version

both master and 5.x.x

### Context

Hi dear Vertx team.

Inside **io.vertx.pgclient.impl.codec.ExtendedQueryCommandCodec** there is comment that either obsolete or at worst case there is missing code. Here it is

```
@Override
void encode(PgEncoder encoder) {
...
if (cmd.paramsList().isEmpty()) {
// We set suspended to false as we won't get a command complete command back from Postgres
this.result = false;
this.decoder.fireCommandResponse(CommandResponse.failure("Can not execute batch query with 0 sets of batch parameters."));
return;
}
```

can you please verify if this is outdated comment or really missed logic of suspending.

### Steps to reproduce

_No response_

### Do you have a reproducer?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.