eclipse-vertx / eclipse-vertx/vertx-openapi

ResponseValidator: No failure in case of not specified reponse body

Open
#17 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
15
Forks
19
PR merge metrics
No merged PRs in 30d

Description

When the openAPI contract does not define a Operation Reponse body:

`"responses": {
"200": {
"description": "Successful hello message"
},`

But the ValidatableResponse contains a response body,
the validation passes successfully **instead of Failing.**

------------------------------------------
**A Test Sample:**

`

OpenAPIContract contract = getContract();
ResponseValidator validator = ResponseValidator.create(vertx, contract);

JsonObject cat = new JsonObject().put("name", "foo");
ValidatableResponse response =
ValidatableResponse.create(200, cat.toBuffer(), "application/json");
validator.validate(response, "operationWithResponseNoBody")
.onSuccess(vr -> logger.info("Validation Success"))
.onFailure(t -> logger.error("Validation Failure: ", t));
`

Output: "Validation Success"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.