eclipse-vertx / eclipse-vertx/vertx-json-schema

Incorrect Vert.x Open API 'multipleOf' validation

Open
#106 1 comment 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Java
Stars
86
Forks
30
PR merge metrics
No merged PRs in 30d

Description

### Version

4.4.1

### Context

After upgrading from version 4.2.7 to 4.4.1, I have noticed that validating a number field which has 'multipleOf 0.001' defined in Open API 3 fails for numbers like 1.001, 1.01, 1.02, but passes for numbers like 0.001, 0.002.

### Do you have a reproducer?

No, but the changes made in the code are transparent.

### Steps to reproduce

The bug was already reported in this issue:
https://github.com/vert-x3/vertx-web/issues/2105

But it was reverted in this commit:
https://github.com/eclipse-vertx/vertx-json-schema/commit/a51e3e3c553be822dc6272fd7e0b341209b85713

### Question

Since the OpenAPI3SchemaParser class which includes the MultipleOfValidatorFactory is marked as deprecated, is there an alternative solution planned for future releases?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.