eclipse-vertx / eclipse-vertx/vertx-grpc

The GrpcClient constructor should add http2ClearTextUpgrade(false) to passed HttpOptions

Open
#27 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
53
Forks
36
Avg merge
5h 49m
Merged PRs (30d)
60

Description

### Version

4.3.7

### Context

The GrpcClient constructors allow you to pass in custom HttpOptions.

Because `httpOptions.setHttp2ClearTextUpgrade(false)` must be set, the constructor should do it for you, like the default constructor does.

### Steps to reproduce

1. Create a client with `GrpcClient.client(vertx, new HttpClientOptions())`.
2. Observe the server replies with an unexpected HTTP/1.1 protocol error.
3. Observe `GrpcClient.client(vertx, new HttpClientOptions().setHttp2ClearTextUpgrade(false))` resolves the issue.

This is a known issue. It is never valid to have this set to `true` (or the default) on a GrpcClient.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.